Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(table): table filters pipe types #9076

Merged
merged 2 commits into from
Sep 19, 2024
Merged

fix(table): table filters pipe types #9076

merged 2 commits into from
Sep 19, 2024

Conversation

andrewmnlv
Copy link
Contributor

Close #

@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Sep 18, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@codecov Codecov
Copy link

codecov bot commented Sep 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.68%. Comparing base (4a26b1a) to head (5cad371).
Report is 128 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9076      +/-   ##
==========================================
- Coverage   75.68%   75.68%   -0.01%     
==========================================
  Files        1216     1227      +11     
  Lines       19068    19197     +129     
  Branches     2091     1968     -123     
==========================================
+ Hits        14432    14529      +97     
- Misses       4592     4629      +37     
+ Partials       44       39       -5
Flag Coverage Δ
summary 75.68% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bundlemon BundleMon
Copy link

bundlemon bot commented Sep 18, 2024

BundleMon

Unchanged files (5)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 286.77KB +10%
✅ demo/browser/vendor.(hash).js
 247.15KB +10%
✅ demo/browser/runtime.(hash).js
 42.31KB +10%
✅ demo/browser/styles.(hash).css
 16.19KB +10%
✅ demo/browser/polyfills.(hash).js
 11.2KB +10%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
✅ demo/browser/*..js
 7.05MB -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@waterplea waterplea merged commit 0635555 into taiga-family:main Sep 19, 2024
28 checks passed
@andrewmnlv andrewmnlv deleted the fix/table-filters-pipe branch September 19, 2024 12:32
@taiga-family-bot taiga-family-bot mentioned this pull request Sep 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@splincode splincode splincode approved these changes

@waterplea waterplea waterplea approved these changes

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi

@vladimirpotekhin vladimirpotekhin Awaiting requested review from vladimirpotekhin

@nsbarsukov nsbarsukov Awaiting requested review from nsbarsukov

@mdlufy mdlufy Awaiting requested review from mdlufy

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewmnlv @waterplea @splincode